doc: update sample output for process.versions #18167
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
tniessen
approved these changes
Jan 15, 2018
|
The commit message should probably say |
jasnell
approved these changes
Jan 15, 2018
cjihrig
approved these changes
Jan 15, 2018
doc/api/process.md
Outdated
| unicode: '8.0', | ||
| cldr: '29.0', | ||
| { http_parser: '2.7.0', | ||
| node: '10.0.0-pre', |
There was a problem hiding this comment.
Really minor nit, but I suggest using an actual release version to avoid any confusion from the -pre.
mhdawson
changed the title
Update so that it includes some of the more recent additions
gireeshpunathil
approved these changes
Jan 16, 2018
JungMinu
approved these changes
Jan 16, 2018
mhdawson
force-pushed
the
process-example
branch
from
16291c6
to
984413c
Compare
|
Pushed commit to address comments. |
richardlau
approved these changes
Jan 16, 2018
joyeecheung
added
the
author ready
|
Landed in 5aa0f3e. |
tniessen
pushed a commit
that referenced
this pull request
Jan 17, 2018
Update so that it includes some of the more recent additions. PR-URL: #18167 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
addaleax
removed
the
author ready
evanlucas
pushed a commit
that referenced
this pull request
Jan 30, 2018
Update so that it includes some of the more recent additions. PR-URL: #18167 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 27, 2018
Update so that it includes some of the more recent additions. PR-URL: #18167 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
Update so that it includes some of the more recent additions. PR-URL: nodejs#18167 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update so that it includes some of the more
recent additions
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc